[TAS-2525] 💄 Purchase CTA button improvement #1948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AuroraHuang22
commented
Nov 13, 2024
•
AuroraHuang22
commented
- - edition button
- - cta button
- - column left UI
- - gift dialog
- - discount + stock label
AuroraHuang22
added a commit
that referenced
this pull request
Nov 13, 2024
nwingt
reviewed
Nov 13, 2024
Comment on lines
31
to
40
| <div class="text-like-green text-[16px] font-500">{{ name }}</div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="flex flex-co whitespace-nowrap"> | ||
| <div v-if="discountInfo" class="text-like-green text-[12px]"> | ||
| {{ discountInfo.originalPriceLabel }} | ||
| </div> | ||
| <div class="text-like-green text-[16px] font-500"> | ||
| {{ priceLabel }} |
There was a problem hiding this comment.
Comment on lines
28
to
30
| <div> | ||
| <NFTStockLabel :stock="stock" /> | ||
| </div> |
There was a problem hiding this comment.
| </div> | ||
| </div> | ||
|
|
||
| <div class="flex flex-co whitespace-nowrap"> |
There was a problem hiding this comment.
???
Suggested change
| <div class="flex flex-co whitespace-nowrap"> | |
| <div class="flex flex-col whitespace-nowrap"> |
There was a problem hiding this comment.
src/components/NFTEditionSelect.vue
Outdated
Comment on lines
33
to
35
| <p class="ml-[8px]"> | ||
| {{ $t('nft_edition_select_confirm_button_text_add_to_cart') }} | ||
| </p> |
There was a problem hiding this comment.
src/components/NFTEditionSelect.vue
Outdated
Comment on lines
6
to
8
| <div class="text-[18px] font-500 text-dark-gray w-full"> | ||
| {{ $t('nft_edition_select_section_label') }} | ||
| </div> |
There was a problem hiding this comment.
src/components/NFTEditionSelect.vue
Outdated
| /> | ||
| </template> | ||
|
|
||
| class="hidden laptop:block border-b-[1px] border-[#ebebebeb] w-full my-[16px]" |
There was a problem hiding this comment.
AuroraHuang22
added a commit
that referenced
this pull request
Nov 13, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Nov 13, 2024
williamchong
requested changes
Nov 13, 2024
Comment on lines
392
to
396
| isAllSoldOut() { | ||
| return [this.formattedCollection].every( | ||
| item => item.stock === 0 || item.priceLabel === undefined | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Why make an single item array? Just check this.formattedCollection without using .every() would do
| }, | ||
| data() { | ||
| // NOTE: If the selected item is out of stock, select another item. | ||
| const items = [...this.items]; |
williamchong
approved these changes
Nov 14, 2024
nwingt
approved these changes
Nov 14, 2024
AuroraHuang22
added a commit
that referenced
this pull request
Nov 15, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.